go vet, go fmt

internal/handlers/common_test.go

@@ -162,7 +162,7 @@ func remove(client *http.Client, urlsuffix, key string) error {
 func RunWith(t *testing.T, d *TestData, fn TestDataFunc) {
 	testdata, err := d.Initialize()
 	if err != nil {
-		t.Fatal("Failed to initialize test data: %s", err)
+		t.Fatalf("Failed to initialize test data: %s", err)
 	}
 	defer func() {
 		err := testdata.Teardown()

internal/handlers/imports.go

@@ -321,11 +321,11 @@ func OFXFileImportHandler(tx *Tx, r *http.Request, user *User, accountid int64)
 	part, err := multipartReader.NextPart()
 	if err != nil {
 		if err == io.EOF {
-			return NewError(3 /*Invalid Request*/)
 			log.Print("Encountered unexpected EOF")
+			return NewError(3 /*Invalid Request*/)
 		} else {
-			return NewError(999 /*Internal Error*/)
 			log.Print(err)
+			return NewError(999 /*Internal Error*/)
 		}
 	}
 

internal/handlers/ofx.go

@@ -898,7 +898,6 @@ func (i *OFXImport) AddInvTransaction(invtran *ofxgo.InvTransaction, account *Ac
 		t, err = i.GetTransferTran(&tran, account)
 	} else {
 		return errors.New("Unrecognized type satisfying ofxgo.InvTransaction interface: " + (*invtran).TransactionType())
-		return nil
 
 	}
 

internal/handlers/transactions.go

@@ -412,8 +412,8 @@ func TransactionHandler(r *http.Request, tx *Tx) ResponseWriterWriter {
 
 		balanced, err := transaction.Balanced(tx)
 		if err != nil {
-			return NewError(999 /*Internal Error*/)
 			log.Print(err)
+			return NewError(999 /*Internal Error*/)
 		}
 		if !transaction.Valid() || !balanced {
 			return NewError(3 /*Invalid Request*/)

internal/handlers/util.go

@@ -34,7 +34,3 @@ func (s SuccessWriter) Write(w http.ResponseWriter) error {
 	fmt.Fprint(w, "{}")
 	return nil
 }
-
-func WriteSuccess(w http.ResponseWriter) {
-	fmt.Fprint(w, "{}")
-}